Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce lower-case image name in GitHub Action #21

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Enforce lower-case image name in GitHub Action #21

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
80529e1
image-name to lower-cse
RaphvK Feb 24, 2024
acc05ef
enforce lower-case image name
RaphvK Feb 24, 2024
65df7ba
remove lower
RaphvK Feb 24, 2024
75fff18
enforce lower-case dev image name
RaphvK Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,18 @@ runs:
- name: Set up Docker buildx
uses: docker/setup-buildx-action@v3

- name: Enforce lower-case image name
id: image-name
uses: ASzc/change-string-case-action@v6
with:
string: ${{ inputs.image-name }}

- name: Enforce lower-case dev image name
id: dev-image-name
uses: ASzc/change-string-case-action@v6
with:
string: ${{ inputs.dev-image-name }}

- name: Build images
id: build-images
shell: bash
Expand All @@ -182,9 +194,9 @@ runs:
TARGET: ${{ inputs.target }}
BASE_IMAGE: ${{ inputs.base-image }}
COMMAND: ${{ inputs.command }}
IMAGE_NAME: ${{ inputs.image-name }}
IMAGE_NAME: ${{ steps.image-name.outputs.lowercase }}
IMAGE_TAG: ${{ inputs.image-tag }}
DEV_IMAGE_NAME: ${{ inputs.dev-image-name }}
DEV_IMAGE_NAME: ${{ steps.dev-image-name.outputs.lowercase }}
DEV_IMAGE_TAG: ${{ inputs.dev-image-tag }}
RMW_IMPLEMENTATION: ${{ inputs.rmw-implementation }}
ROS_DISTRO: ${{ inputs.ros-distro }}
Expand Down Expand Up @@ -239,7 +251,7 @@ runs:
TARGET: ${{ inputs.target }}
BASE_IMAGE: ${{ inputs.base-image }}
COMMAND: ${{ inputs.command }}
IMAGE_NAME: ${{ inputs.image-name }}
IMAGE_NAME: ${{ steps.image-name.outputs.lowercase }}
IMAGE_TAG: ${{ inputs.image-tag }}
DEV_IMAGE_NAME: ${{ inputs.dev-image-name }}
DEV_IMAGE_TAG: ${{ inputs.dev-image-tag }}
Expand Down Expand Up @@ -275,7 +287,7 @@ runs:
TARGET: ${{ inputs.target }}
BASE_IMAGE: ${{ inputs.base-image }}
COMMAND: ${{ inputs.command }}
IMAGE_NAME: ${{ inputs.image-name }}
IMAGE_NAME: ${{ steps.image-name.outputs.lowercase }}
IMAGE_TAG: latest
DEV_IMAGE_NAME: ${{ inputs.dev-image-name }}
DEV_IMAGE_TAG: latest-dev
Expand Down
Loading