Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility to pass custom cmake args to colcon build #46

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Add possibility to pass custom cmake args to colcon build #46

merged 4 commits into from
Jan 21, 2025

Conversation

jpbusch
Copy link
Collaborator

@jpbusch jpbusch commented Dec 23, 2024 •
edited by lreiher
Loading

  • new ci variable: cmake-args / CMAKE_ARGS
  • default: "-DCMAKE_BUILD_TYPE=Release"

lreiher
lreiher previously approved these changes Dec 23, 2024
View reviewed changes
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
jpbusch
jpbusch commented Dec 23, 2024
View reviewed changes
scripts/build.sh Outdated Show resolved Hide resolved
@akloeker
Copy link
Member

The PR should be ready now. The build_image() function had to be refactored to fix a bug with space separated arguments. As a bonus, the script is now more concise.

@akloeker akloeker marked this pull request as ready for review January 15, 2025 16:46
lreiher
lreiher previously approved these changes Jan 21, 2025
View reviewed changes
@lreiher lreiher merged commit 4116eea into main Jan 21, 2025
6 checks passed
@lreiher lreiher deleted the custom-cmake-args branch January 21, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akloeker akloeker akloeker left review comments

@lreiher lreiher lreiher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpbusch @akloeker @lreiher