DtNavMeshQuery allocation fixes #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 12, 2024 16:04
…uffer rent in query. (cherry picked from commit c8104cec4dd2f3a480720052ddba17cfc6b4fb56)
(cherry picked from commit 6fe6844efdc880c5695136f24f349908e204c07d)
(cherry picked from commit ff930712ee2c806753f39b7565f50e03a988691f)
|
Uhh, this PR wasn't finished yet ^^' |
|
Got it. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced array allocation with rented buffer. However there's still an issue. RcRentedArray is a class. So making new instance will allocate memory in heap. Making it a struct will solve the issue. I didn't because it will break tests.
Instances of IDtPolyQuery are also allocating every frame. Would be better to turn them structs. Then make all methods accepting queries to be generic. It is more risky change.