Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from circleci to github actions #216

Closed
wants to merge 1 commit into from

Conversation

thodkatz
Copy link
Collaborator

@thodkatz thodkatz commented Sep 3, 2024

Following the github workflow design from ilastik.

Github actions could be handly for testing multi-platform.

@thodkatz thodkatz force-pushed the ci-multiple-os branch 2 times, most recently from 8e2558b to 7867116 Compare September 3, 2024 21:25
Copy link
Collaborator

@k-dominik k-dominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @thodkatz,

awesome that you're migrating there!!! I left some comments that are mere reminders that we are living in an ever evolving ecosystem ;)

auto-activate-base: true
activate-environment: ""
channel-priority: strict
miniforge-variant: Mambaforge
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should now be miniforge

activate-environment: ""
channel-priority: strict
miniforge-variant: Mambaforge
use-mamba: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessary (it's the default now)

Comment on lines +28 to +29
mamba env create -n tiktorch-env --file environment.yml
mamba activate tiktorch-env
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use conda instead of mamba - mamba is only carried along for compatibility (when installed). Functionality is all available via conda

miniforge-variant: Mambaforge
use-mamba: true
- name: install common conda dependencies
run: mamba install -n base -c conda-forge mamba boa setuptools_scm -y
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mamba not necessary, boa should be replaced by conda-build (relatively sure, maybe confirm locally that there is no significant timing difference between conda mambabuild and conda build...)

@thodkatz
Copy link
Collaborator Author

thodkatz commented Sep 4, 2024

Following up #217

@thodkatz thodkatz closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants