-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imjoy [WIP] #88
base: main
Are you sure you want to change the base?
Imjoy [WIP] #88
Conversation
@Fynn Could you point me to an example image? And which model should I try? I have been working on the bioimage.io website and made some progress, now it’s time to put some real model there. Would be great if you can start to send PR to the models repo. My next plan is to make the Ilastik bioengine app work. |
@FynnBe I just tried the code, however, I got an error when I try to load the Unet2D model from bioimage.io: https://bioimage.io/?model=2D%20UNet%20Nuclei%20Broad
Full stack trace here: https://gist.github.com/oeway/7f32db7384f242cab64fe5e81faf6ce6 |
I fixed the released unet2d model zip. it should work now |
ok, great, will try. BTW, do you have a test image included in the zip? |
not yet, I thought I'll add |
Great, I think the test image and the covers should be different images. test image is full resolution , perhaps 16bits, which we use to feed into the network, ideally also provide a ground-truth image to validate the result with CI. The cover image is only for display on the website, so it should have low-resolution, small size, sometimes in artistic style. |
sure, but where do we host the cover images? one option would be to add them into the zip as well, another to just make covers a list of urls. |
no, I suppose we should though... I'm on it |
Right, I would host the cover images together with the yaml (same folder or at least in the same github repo), then get a We will generate the zip file so it will have the cover images in the zip in the near future. For now, I would add the cover images + test images in the zip file manually. |
would it be possible to construct that raw github link on the fly, from the raw github model.yaml link and the relative file path within that yaml... ? |
Yes, we are doing that, in the yaml you can use relative path to the cover image/readme etc., we have code to resolve it. |
FYI: I made a BioEngine App based on your example, and it runs smoothly in ImJoy with MyBinder: bioimage-io/bioimage-io-resources#7 |
add an imjoy plugin