Add text outline #1247
Draft
Add text outline #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-simple-charts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Love it. Love it so much I don't think it should be an option (or it should at least default to |
michaelchadwick
force-pushed
the
add-text-outline
branch
from
3de307d to
7c14e03
Compare
|
@jrjohnson Should the default=true be a part of this PR, though? |
|
Yes. I'm more and more inclined to say this is non-optional and doesn't just default to true, but is always true. Simplifies the code in this PR so I think it goes here. |
michaelchadwick
force-pushed
the
add-text-outline
branch
from
7c14e03 to
5f302f9
Compare
michaelchadwick
force-pushed
the
add-text-outline
branch
from
5f302f9 to
44a7b19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, only Donut charts incorporate this, but it could easily be added to other charts