adds data tables to more course visualizations #7946
Conversation
stopfstedt
force-pushed
the
course_viz_vocabs_data_tables
branch
6 times, most recently
from
328508d to
dfceb22
Compare
|
|
|
this course was used for the screen shot above ... http://localhost:4200/data/courses/2224 2224 is the course ID |
@dartajax - not sure where we left it on this particular aspect. render a donut here instead, or not? |
also - the graph is "staying within it's quadrant", but it's bumping up against the next one.
i could give it a bit of room though
@dartajax - given some extra room - would that cut it for you? |
I think I like the bars myself but have put it up for team discussion - it seems like more information is available sooner - and I like that. |
Why not just make it straight quadrants (quarters) of the screen available to each visualization / graph in case we end up converting the Instructors to be bar chart as well? The extra room is helpful though and would cut it for me. |
|
formatting suggestion ... old ... updated ... |
i like this, will give it a try. thanks for the suggestion. |
stopfstedt
force-pushed
the
course_viz_vocabs_data_tables
branch
7 times, most recently
from
4b4ff66 to
b159f00
Compare
stopfstedt
changed the title
stopfstedt
force-pushed
the
course_viz_vocabs_data_tables
branch
from
6f280e2 to
fc46a82
Compare
stopfstedt
force-pushed
the
course_viz_vocabs_data_tables
branch
2 times, most recently
from
c9ce955 to
5f44c7f
Compare
standardize on the height of the course/objectives viz across the board.
bar chart across the board.
we have no way to present them in the graph, so let's not include them at all.
convert course/instructor/session-types graph from donut to the more appropriate bar-chart.
- destructuring code to make it a bit more readable - chain methods where possible to reduce cognitive load introduced by unnecessary local vars - ensure that tooltip content is always html safe
…ith data-table tests, filter out zero-data elements.
this required further consolidation of data-loading getters to make the loading state check reliable - otherwise the "no data" message will blink in while data is still being loaded. i've added a spinner while at it since there's a noticable delay with content rendering.
we need to distringuish between unlinked target entities, and linked target entities without instructional time. only show a "no data" message if there's nothing linked at all. while at it - fix content of flash while data is loading by consolidating getters. adds links to sub-visualizations in the data tables.
stopfstedt
force-pushed
the
course_viz_vocabs_data_tables
branch
from
1d6a649 to
1af7733
Compare
fixes ilios/ilios#5584
fixes ilios/ilios#5583