Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actually save the change. #7999

Closed
wants to merge 1 commit into from

Conversation

stopfstedt
Copy link
Member

fixes ilios/ilios#5611

as an aside - i seem to be unable to provide proper test coverage for this. tried to handle this in an acceptance test - make the change, "reload" the page by visiting it again, then check if the made changes are sticking. seems straightforward, but i can't get the page object in the acceptance to "reset" on consecutive calls to page.visit() - it's seems to be holding on to its current state, so it's actually not reloading/resetting. any ideas on how to get this to work?

@stopfstedt stopfstedt marked this pull request as ready for review July 24, 2024 17:52
@stopfstedt stopfstedt requested a review from jrjohnson as a code owner July 24, 2024 17:52
@stopfstedt
Copy link
Member Author

upon further inspection, this is the right solution to the wrong problem. turns out that changes are not supposed to be persisted when the in-place editor is closed, but when the competency manager is closed via its "done" button.

this works as intended.

@stopfstedt stopfstedt closed this Jul 24, 2024
@dartajax
Copy link
Member

I think I fell for this the other day too. 2 step shuffle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating Competency in School Manager not sticking
2 participants