Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Week at a Glance now translates month names when displaying #8001

Merged

Conversation

michaelchadwick
Copy link
Contributor

Fixes ilios/ilios#5606

Need to add more tests, probably

@michaelchadwick
Copy link
Contributor Author

Added some tests for switching language.

@michaelchadwick michaelchadwick marked this pull request as ready for review July 25, 2024 21:41
@@ -206,7 +213,7 @@ module('Integration | Component | week glance', function (hooks) {
assert.ok(true, 'no a11y errors found!');
});

test('click to expend', async function (assert) {
test('click to expand', async function (assert) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😀

@dartajax dartajax merged commit a6fcada into ilios:master Jul 26, 2024
44 checks passed
@michaelchadwick michaelchadwick deleted the frontend-5606-waag-translate-month-names branch July 26, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weekend at a Glance does not translate month names
3 participants