Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Deploy #8009

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Conversation

jrjohnson
Copy link
Member

@jrjohnson jrjohnson commented Jul 25, 2024

I have:

  • Added a deploy test, not sure how useful it is compared to our build test, but we'll see
  • Split deploys up into a matrix instead of using parallel pnpm tasks
  • Added notification if PRs fail to deploy

This doesn't fix our current deploy issue, but it will make it easier to figure out what is wrong (and next time as well).

So we can test all the build steps for these
Not sure if this will ever catch anything, but it's probably a good idea
to run through our ember-cli-deploy pipeline as part of our CI process.
Just in case.
Doing this with parallel pnpm jobs is making it difficult to see, and
understand, failures.
@jrjohnson jrjohnson marked this pull request as ready for review July 25, 2024 22:01
@jrjohnson jrjohnson requested a review from stopfstedt as a code owner July 25, 2024 22:01
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one.

fail-fast: false
matrix:
node-version: [20]
workspace:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this a lot!

@stopfstedt stopfstedt enabled auto-merge July 25, 2024 22:38
@stopfstedt stopfstedt merged commit 9b21f04 into ilios:master Jul 25, 2024
43 checks passed
@jrjohnson jrjohnson deleted the matrix-deploys-and-test branch July 26, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants