Material Manager Updates #8257
Merged
Material Manager Updates #8257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing our existing validations with yup equivalents. Fixes a couple of issues with the values key as well while working on this.
Because this component is only ever rendered with a material and a different material cannot be passed in we can do all of the data loading in the constructor and not worry about the behavior in did-update. I was also able to remove the spinner as the only data included in the manager that isn't already loaded is some mesh tree meta data when mesh terms are attached.
jrjohnson
requested review from
michaelchadwick and
stopfstedt
as code owners
michaelchadwick
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the validation and removed the render modifier for the
LearningmaterialManagercomponent.Because this component is only ever rendered with a material and a
different material cannot be passed in we can do all of the data loading
in the constructor and not worry about the behavior in did-update.
I was also able to remove the spinner as the only data included in the
manager that isn't already loaded is some mesh tree meta data when mesh
terms are attached.