replaces ember render modifiers in curr inv new report component. #8260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamlines the initialization and tracking of report year selections.
stopfstedt
requested review from
jrjohnson and
michaelchadwick
as code owners
michaelchadwick
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
LGTM, although it would be nice to better understand why we were using a findById method before, but now do not @stopfstedt
i simplified the way how the (pre-)selected year is determined - previously, we'd "find" the current year (and then track it) as an object from an array of objects. now, we're tracking the year as an integer, which makes |
stopfstedt
deleted the
replace_render_modifiers_in_curr_inv_new_report_component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
streamlines the initialization and tracking of report year selections.
refs ilios/ilios#5374