Remove PublicationMenuComponent render modifiers #8264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelchadwick
requested review from
jrjohnson and
stopfstedt
as code owners
stopfstedt
requested changes
Dec 13, 2024
| menuElement.querySelector('button:first-of-type').focus(); | ||
| focusFirstLink = task(async () => { | ||
| await timeout(1); | ||
| document.querySelector('.publication-menu .menu button:first-of-type').focus(); |
There was a problem hiding this comment.
this works since there's only ever one menu open at the same time.
however, querying from the doc root is brittle.
i'm suggesting bringing the menu element back as input argument, then making the DOM query from that element instead.
would require identifying the menu element from the event target in the click handler -for example, if the clicked element is nested within the menu ("menu item"), you'll have to traverse the DOM tree up from it.
| menuElement.querySelector('button:first-of-type').focus(); | ||
| focusFirstLink = task(async () => { | ||
| await timeout(1); | ||
| document.querySelector('.publication-menu .menu button:first-of-type').focus(); |
There was a problem hiding this comment.
please see my comment about the course-variant of this component.
stopfstedt
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs ilios/ilios#5374