Remove VisualizerProgramYearObjectives render modifiers #8267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelchadwick
requested review from
jrjohnson and
stopfstedt
as code owners
jrjohnson
requested changes
Dec 13, 2024
| const classOfYear = this.intl.t('general.classOf', { year }); | ||
| this.programYearName = cohort.title ?? classOfYear; | ||
|
|
||
| this.data = await this.getData(programYear); | ||
| this.data = await this.getData(this.programYear); |
There was a problem hiding this comment.
This doesn't time out correctly if the program year isn't already loaded. It could return null. This fix is a bit more complicated, but worth the time:
- Remove the
loadentirely - Create a
TrackedAsyncDatathat callsgetDatausing the program year. Until program year exists it should return null. - Probably lots of adjustment and cleanup to get that to work
There was a problem hiding this comment.
Yeah, this one's gonna need more work. Back to the mines...
There was a problem hiding this comment.
@jrjohnson Any idea why the links to these visualizations only exist on local, but not dev?
There was a problem hiding this comment.
@michaelchadwick the visibility of these links is controlled via a feature flag.
for reference, see:
https://github.com/ilios/frontend/blob/master/packages/frontend/app/components/program-year/overview.hbs#L7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs ilios/ilios#5374
Two odd things I found: