Replace ember render modifiers in learner group root component #8281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
force-pushed
the
replace_ember_render_modifiers_in_learner_group_components
branch
from
9a68207 to
33af894
Compare
stopfstedt
changed the title
…nvert read-only learnerGroupId prop into a getter.
…only place where it is actually used..
i split this into two - one for the user manager subcomponent, and one for the membership list subcomponent. edit vs view mode, the data is slightly different. i hope this makes things a bit more grokkable.
… obsolete load() task.
stopfstedt
force-pushed
the
replace_ember_render_modifiers_in_learner_group_components
branch
from
e340ad3 to
bd99907
Compare
stopfstedt
requested review from
jrjohnson and
michaelchadwick
as code owners
jrjohnson
approved these changes
Dec 20, 2024
| {{t "general.uploadGroupAssignments"}} | ||
| {{else}} | ||
| {{t "general.members"}} | ||
| ({{this.usersForUserManager.length}}) |
There was a problem hiding this comment.
Surprised at how much more readable this is.
| this.url = this.args.learnerGroup.url; | ||
| } | ||
|
|
||
| @cached |
There was a problem hiding this comment.
Nothing async here, doesn't need to be @cached
| } | ||
|
|
||
| get learnerGroupTitle() { | ||
| return this.args.learnerGroup.title; |
There was a problem hiding this comment.
curious why this is a getter, but location and url are both set in the constructor?
There was a problem hiding this comment.
Oh, never mind. Those can be changed. Got it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs ilios/ilios#5374