Fix New Year Errors #8288
Merged
Fix New Year Errors #8288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the start and end of the year we need to pay special attention to the week, otherwise we get bad results.
Tests every single day around the year change against the reality we expect.
If we pass invalid data to this component such as a week that cannot exist in a year we should die much less horribly than we do right now. Kick out an error, and then don't display a title.
This test doesn't cover this issue.
Doing this by modifying the current year didn't work. I'm not 100% sure why, but the right way to run a single value into a Luxon DateTime is with fromObject so I switched to this. This prevents us from passing a bad combination of weeks in a year and the year and blowing up the page.
jrjohnson
requested review from
michaelchadwick and
stopfstedt
as code owners
stopfstedt
approved these changes
Dec 30, 2024
stopfstedt
reviewed
Dec 30, 2024
Comment on lines
+21
to
+25
| // In this component the week always starts on Sunday, but luxon's starts on Monday | ||
| // If today is sunday, we need to add a week to get the correct Thursday | ||
| if (DateTime.now().weekday === 7) { | ||
| return thursday.plus({ weeks: 1 }); | ||
| } |
There was a problem hiding this comment.
will need revisiting. Spanish and French locales have a start of the week on Monday, not Sunday.
Luxon provides a locale-aware function for getting the day-number of the start of the week. https://moment.github.io/luxon/api-docs/index.html#infogetstartofweek
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered several interconnected issues around the end of 2024 and the start of 2025. The most serious of these was that opening week at a glance all weeks for 2025 blew up as we were asking for 53 weeks in a 52 week year. This fixes ilios/ilios#5908.
I also discovered that the wrong title was appearing at the top of the dashboard week view during this time period as well.