Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes dependency on ember-cli-clean-css. #8294

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

stopfstedt
Copy link
Member

from this plugin's README:

Note

This addon is not needed and is NOT used when embroider is enabled.

we're building with embroider in frontend, so let's remove this dependency.

refs ilios/ilios#5912

We're building with embroider across the board now, and this library
does not interact with embroider builds at all.
@stopfstedt stopfstedt marked this pull request as ready for review January 6, 2025 21:00
Copy link
Member

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@dartajax dartajax added the run ui tests Run the expensive UI tests label Jan 6, 2025
@dartajax dartajax merged commit 6e33412 into ilios:master Jan 6, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run ui tests Run the expensive UI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants