implements request batching #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prep-work to implement request batching.
stopfstedt
force-pushed
the
batch_requests_by_ids
branch
2 times, most recently
from
93eb8e1 to
09fe869
Compare
stopfstedt
force-pushed
the
batch_requests_by_ids
branch
from
09fe869 to
e7dffd7
Compare
jrjohnson
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #69
i decided to apply chunking/batching on all requests if applicable, not just for users requests.
note on the reduced request params limit - 250 is on the safe side, 1000 was not.
for context - the previous, cURL-based HTTP client in use was not encoding request parameters, whereas the new, Guzzle-based HTTP client does. which makes for much more verbose URLs.
for example, see these logged requests on the server-side:
Moodle 4.3, cURL client (ignore the
limitquery param)GET /api/v3/users?limit=1000&filters[id][]=4520&filters[id][]=7572&filters[id][]=7584&filters[id][]=7616&filters[id][]=7634&filters[id][]=7655&filters[id][]=7674&filters[id][]=7794...vs Moodle 4.4, Guzzle client
GET /api/v3/users?filters%5Bid%5D%5B%5D=4520&filters%5Bid%5D%5B%5D=7572&filters%5Bid%5D%5B%5D=7584&filters%5Bid%5D%5B%5D=7616&filters%5Bid%5D%5B%5D=7634&filters%5Bid%5D%5B%5D=7655&filters%5Bid%5D%5B%5D=7674&filters%5Bid%5D%5B%5D=7794...