Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thermal interface for orthotropic cases #1009

Merged
merged 20 commits into from
Mar 8, 2024
Merged

Conversation

tulioricci
Copy link
Collaborator

@tulioricci tulioricci commented Mar 3, 2024

  • Include normal projection of thermal conductivity for orthotropic cases.
  • Add extra option to test in test_multiphysics
  • Force thermal conductivity to be DOFArray sooner for diffusion operator.

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@tulioricci tulioricci marked this pull request as ready for review March 4, 2024 14:27
@tulioricci tulioricci requested a review from majosm March 4, 2024 14:27
mirgecom/diffusion.py Outdated Show resolved Hide resolved
test/test_multiphysics.py Outdated Show resolved Hide resolved
test/test_multiphysics.py Show resolved Hide resolved
test/test_multiphysics.py Outdated Show resolved Hide resolved
@tulioricci tulioricci requested a review from majosm March 7, 2024 17:56
mirgecom/multiphysics/thermally_coupled_fluid_wall.py Outdated Show resolved Hide resolved
mirgecom/multiphysics/thermally_coupled_fluid_wall.py Outdated Show resolved Hide resolved
test/test_multiphysics.py Outdated Show resolved Hide resolved
test/test_multiphysics.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@majosm majosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tulioricci tulioricci enabled auto-merge (squash) March 7, 2024 20:34
@tulioricci tulioricci disabled auto-merge March 7, 2024 20:36
@tulioricci tulioricci enabled auto-merge (squash) March 7, 2024 20:36
@tulioricci tulioricci disabled auto-merge March 7, 2024 22:09
@tulioricci tulioricci enabled auto-merge (squash) March 8, 2024 03:19
@tulioricci tulioricci disabled auto-merge March 8, 2024 03:20
@tulioricci tulioricci enabled auto-merge (squash) March 8, 2024 04:56
@tulioricci tulioricci merged commit 5e6279b into main Mar 8, 2024
12 of 13 checks passed
@tulioricci tulioricci deleted the tulio/ortho_kappa branch March 8, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants