Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify caches #1042

Closed
wants to merge 5 commits into from
Closed

Unify caches #1042

wants to merge 5 commits into from

Conversation

matthiasdiener
Copy link
Member

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@matthiasdiener matthiasdiener self-assigned this May 24, 2024
@matthiasdiener
Copy link
Member Author

This sometimes fails with (via @MTCam):

  File "/p/gpfs1/mtcampbe/CEESD/AutomatedTesting/MIRGE-Timing/timing/emirge/loopy/loopy/schedule/__init__.py", line 2427, in get_one_linearized_kernel
    schedule_cache.store_if_not_present(sched_cache_key, result)
  File "/p/gpfs1/mtcampbe/CEESD/AutomatedTesting/MIRGE-Timing/timing/emirge/miniforge3/envs/nozzle.lazy.timing.env/lib/python3.11/site-packages/pytools/persistent_dict.py", line 568, in store_if_not_present
    self.store(key, value, _skip_if_present=True, _stacklevel=1 + _stacklevel)
  File "/p/gpfs1/mtcampbe/CEESD/AutomatedTesting/MIRGE-Timing/timing/emirge/miniforge3/envs/nozzle.lazy.timing.env/lib/python3.11/site-packages/pytools/persistent_dict.py", line 725, in store
    LockManager(cleanup_m, self._lock_file(hexdigest_key),
  File "/p/gpfs1/mtcampbe/CEESD/AutomatedTesting/MIRGE-Timing/timing/emirge/miniforge3/envs/nozzle.lazy.timing.env/lib/python3.11/site-packages/pytools/persistent_dict.py", line 150, in __init__
    raise RuntimeError("waited more than one minute "
RuntimeError: waited more than one minute on the lock file '/p/gpfs1/mtcampbe/CEESD/AutomatedTesting/MIRGE-Timing/timing/timing-run-caches/xdg-cache/pytools/pdict-v4-loopy-schedule-cache-v4-2024.1-islpy2023.2.5-cgen2020.1-cc795034cc40d49deed34705ca594c96f407a70f-v1-py3.11.8.final.0/ce4930838a82de39199da84f1d4aff9b216cfa3993e844defbaec7a6563dedae.lock' -- something is wrong

@matthiasdiener matthiasdiener marked this pull request as ready for review June 20, 2024 14:58
@matthiasdiener
Copy link
Member Author

Nightly tests on Lassen seem to run fine with this PR.

@matthiasdiener matthiasdiener enabled auto-merge (squash) June 20, 2024 15:00
@matthiasdiener matthiasdiener marked this pull request as draft August 12, 2024 17:40
auto-merge was automatically disabled August 12, 2024 17:40

Pull request was converted to draft

@matthiasdiener matthiasdiener deleted the unify-caches branch September 11, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants