Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated loopy #1047

Merged
merged 12 commits into from
Jul 20, 2024
Merged

Use updated loopy #1047

merged 12 commits into from
Jul 20, 2024

Conversation

MTCam
Copy link
Member

@MTCam MTCam commented Jul 17, 2024

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@MTCam MTCam marked this pull request as ready for review July 20, 2024 02:48
Copy link
Member

@matthiasdiener matthiasdiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@MTCam MTCam merged commit 24e73a6 into pyvisfile-editable Jul 20, 2024
13 checks passed
@MTCam MTCam deleted the use-pilot-loopy branch July 20, 2024 03:15
matthiasdiener added a commit that referenced this pull request Jul 20, 2024
* Minor update - fix CI failures (#1047)

Co-authored-by: Mike Campbell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants