Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make compatible with non-coupling-enabled versions of grudge v3 #1048

Merged
merged 19 commits into from
Jul 27, 2024

Conversation

matthiasdiener
Copy link
Member

@matthiasdiener matthiasdiener commented Jul 22, 2024

Followup of #898.

TODO:


Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@matthiasdiener matthiasdiener self-assigned this Jul 22, 2024
@matthiasdiener
Copy link
Member Author

This is ready for a first look @majosm @MTCam @inducer. The production tests probably have no chance of succeeding (but I think this isn't the goal).

@MTCam
Copy link
Member

MTCam commented Jul 23, 2024

I don't have a problem with anything being done here, except the hamstringing of the prediction tests. If prediction tests can't be run, then nothing can stop us from checking things in that break prediction - which has caused us great trouble multiple times in the not-too-distant past.

@matthiasdiener
Copy link
Member Author

matthiasdiener commented Jul 23, 2024

I don't have a problem with anything being done here, except the hamstringing of the prediction tests. If prediction tests can't be run, then nothing can stop us from checking things in that break prediction - which has caused us great trouble multiple times in the not-too-distant past.

Just to clarify, this PR currently includes changing the production branches of depending packages to main (596894d). This is temporary, to demonstrate that the non-coupling-needing tests can pass. This will be reversed in case this PR is going to be merged.

@MTCam
Copy link
Member

MTCam commented Jul 23, 2024

I don't have a problem with anything being done here, except the hamstringing of the prediction tests. If prediction tests can't be run, then nothing can stop us from checking things in that break prediction - which has caused us great trouble multiple times in the not-too-distant past.

Just to clarify, this PR currently includes changing the production branches to main (596894d). This is temporary, to demonstrate that the non-coupling-needing tests can pass. This will be reversed in case this PR is going to be merged.

Ah, I see now. So is the plan that external packages can do their "upstream mirgecom tests" in CI by using run-examples.sh, and only compatible tests will be run?

@matthiasdiener
Copy link
Member Author

I don't have a problem with anything being done here, except the hamstringing of the prediction tests. If prediction tests can't be run, then nothing can stop us from checking things in that break prediction - which has caused us great trouble multiple times in the not-too-distant past.

Just to clarify, this PR currently includes changing the production branches to main (596894d). This is temporary, to demonstrate that the non-coupling-needing tests can pass. This will be reversed in case this PR is going to be merged.

Ah, I see now. So is the plan that external packages can do their "upstream mirgecom tests" in CI by using run-examples.sh, and only compatible tests will be run?

Yes, run-examples.sh, or pytest.

@MTCam
Copy link
Member

MTCam commented Jul 23, 2024

I don't have a problem with anything being done here, except the hamstringing of the prediction tests. If prediction tests can't be run, then nothing can stop us from checking things in that break prediction - which has caused us great trouble multiple times in the not-too-distant past.

Just to clarify, this PR currently includes changing the production branches to main (596894d). This is temporary, to demonstrate that the non-coupling-needing tests can pass. This will be reversed in case this PR is going to be merged.

Ah, I see now. So is the plan that external packages can do their "upstream mirgecom tests" in CI by using run-examples.sh, and only compatible tests will be run?

Yes, run-examples.sh, or pytest.

I don't think it can be "or". Upstream pkg's dowstream mirgecom tests should include the examples, at least, if not exclusively.

@matthiasdiener matthiasdiener marked this pull request as ready for review July 25, 2024 16:47
@matthiasdiener
Copy link
Member Author

This is ready for review. The Production CI error is due to a merge issue.

examples/advdiff-tpe.py Outdated Show resolved Hide resolved
Copy link
Member

@MTCam MTCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MTCam MTCam merged commit 61bd76a into main Jul 27, 2024
13 checks passed
@MTCam MTCam deleted the optional-coupling-v3 branch July 27, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants