Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require mpi4py v4 instead of git version #1052

Merged
merged 1 commit into from
Aug 12, 2024
Merged

require mpi4py v4 instead of git version #1052

merged 1 commit into from
Aug 12, 2024

Conversation

matthiasdiener
Copy link
Member

@matthiasdiener matthiasdiener commented Aug 12, 2024

Followup of #972.

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@matthiasdiener matthiasdiener self-assigned this Aug 12, 2024
Copy link
Member

@MTCam MTCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@matthiasdiener matthiasdiener enabled auto-merge (squash) August 12, 2024 17:44
@matthiasdiener matthiasdiener merged commit 03860e7 into main Aug 12, 2024
13 checks passed
@matthiasdiener matthiasdiener deleted the mpi4py-4 branch August 12, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants