-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit pocl to <6 (test revert numpy type promotion) #1055
Conversation
What's wrong with pocl 6? This is something I've seen, but it should not affect mirgecom. |
We have seen substantial slowdowns in our prediction cases with both the new type promotion code as well as pocl-5 vs pocl-6:
For some reason, pocl-6 seems to affect mostly the CUDA devices, while the type promotion code mostly affects the CPU runs. |
Yikes. Could you hunt for the simplest example that exhibits the issue and compare the PTX for both? This tool may be able to help. Also, could you file an issue for this? (Since I'm not sure this PR is the best place for the discussion.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👎
Related: inducer/pytato#538, inducer/pytato#510
Questions for the review: