Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AMD GPU oversubscription check #1059

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Conversation

matthiasdiener
Copy link
Member

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@matthiasdiener matthiasdiener self-assigned this Aug 26, 2024
@matthiasdiener matthiasdiener marked this pull request as ready for review August 28, 2024 14:35
Copy link
Member

@MTCam MTCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@matthiasdiener matthiasdiener enabled auto-merge (squash) August 28, 2024 18:16
@matthiasdiener matthiasdiener merged commit af8b7ee into main Aug 28, 2024
13 checks passed
@matthiasdiener matthiasdiener deleted the oversubscription-amd branch August 28, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants