Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document Expression-->ExpressionNode #1088

Merged
merged 1 commit into from
Nov 25, 2024
Merged

document Expression-->ExpressionNode #1088

merged 1 commit into from
Nov 25, 2024

Conversation

MTCam
Copy link
Member

@MTCam MTCam commented Nov 25, 2024

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@MTCam MTCam requested a review from matthiasdiener November 25, 2024 13:54
@MTCam MTCam enabled auto-merge (squash) November 25, 2024 15:01
@MTCam MTCam merged commit 7319d62 into main Nov 25, 2024
12 of 13 checks passed
@MTCam MTCam deleted the fix-pymbolic-type-doc branch November 25, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants