Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some peripheral utils for prediction #873

Merged
merged 14 commits into from
Apr 20, 2023
Merged

Update some peripheral utils for prediction #873

merged 14 commits into from
Apr 20, 2023

Conversation

MTCam
Copy link
Member

@MTCam MTCam commented Apr 10, 2023

Some utilities used in prediction (and adjacent) simulations:

  • read_and_distribute_yaml: Utility used by prediction drivers to read yaml config data
  • boundary_report: utility to give a report on the numbers of mesh points on all surfaces and boundaries, used in performance analysis and modeling
  • geometric_mesh_partitioner: Used to give a 1D domain decomp for prediction meshes (dag splat mitigation)
  • get_number_of_tetrahedron_nodes: Utility used for node counting in memory analysis and filter testing
  • configurate: updated to be smarter about how it assigns default values/types

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@MTCam MTCam added enhancement New feature or request Production Feeder Feeds the production branch labels Apr 10, 2023
@MTCam MTCam marked this pull request as draft April 11, 2023 16:34
@MTCam MTCam marked this pull request as ready for review April 17, 2023 15:11
Copy link
Collaborator

@majosm majosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mostly, just added a few suggestions.

mirgecom/simutil.py Outdated Show resolved Hide resolved
mirgecom/simutil.py Outdated Show resolved Hide resolved
mirgecom/simutil.py Outdated Show resolved Hide resolved
mirgecom/simutil.py Outdated Show resolved Hide resolved
mirgecom/simutil.py Outdated Show resolved Hide resolved
mirgecom/simutil.py Outdated Show resolved Hide resolved
mirgecom/simutil.py Outdated Show resolved Hide resolved
mirgecom/simutil.py Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
mirgecom/simutil.py Outdated Show resolved Hide resolved
mirgecom/simutil.py Outdated Show resolved Hide resolved
mirgecom/simutil.py Outdated Show resolved Hide resolved
mirgecom/simutil.py Outdated Show resolved Hide resolved
mirgecom/simutil.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@majosm majosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MTCam MTCam merged commit 73d51d8 into main Apr 20, 2023
@MTCam MTCam deleted the update-utils branch April 20, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Production Feeder Feeds the production branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants