Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coupling of domains for NS equations #900

Closed
wants to merge 5 commits into from

Conversation

tulioricci
Copy link
Collaborator

@tulioricci tulioricci commented May 8, 2023

  • Coupling of domains governed by NS equations in multiphysics_coupled_fluid_wall.py. One of them is (will be) the flow inside a porous media (initial implementation in its companion PR Add wall-only part of Y3 phenolics model #875, an additional PR is necessary to finish it).
  • Uses the coupling ideas from (Attempt to simplify/generalize coupling #902)
  • Include radiation as a sink term (Add radiation #893)
  • This replaces the driver-implemented Y2 oxidation model and extends to solve species diffusion with a tight coupling of all species with the external flow (the second NS domain, fluid-only).
  • Added multiple-coupled-volumes.py as an example to show multiple couplings.
  • Removed multiple-volumes.py from the examples.
  • Added tests to test-multiphysics.py

TODO:

  • Avoid having constants/hard-coded stuff in the models. The proper values should be given by the user. How to generalize?

Wondering:

  • Move coupling to its own section in the docs instead of inside the "operators"
  • Shuffle wall_model and multiphysics to produce condution-only and porous flow files instead.

For future work:

  • Include porous flow so the NS coupling makes sense

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@tulioricci tulioricci changed the title Coupling of NS for two different domains Coupling of NS for two separate domains May 9, 2023
@tulioricci tulioricci requested a review from majosm May 12, 2023 17:53
@tulioricci tulioricci marked this pull request as ready for review May 12, 2023 18:38
@tulioricci tulioricci marked this pull request as draft May 16, 2023 20:51
@tulioricci tulioricci changed the base branch from main to tulio/phenolics-v0 May 17, 2023 20:30
@tulioricci tulioricci changed the title Coupling of NS for two separate domains Coupling of N separate domains for heat and NS equations May 24, 2023
@majosm
Copy link
Collaborator

majosm commented Jul 7, 2023

@tulioricci, is this branch up to date with your local changes? I can take a stab at updating it post-#902.

@tulioricci tulioricci changed the title Coupling of N separate domains for heat and NS equations Coupling of domains for NS equations Jul 10, 2023
Base automatically changed from tulio/phenolics-v0 to main July 12, 2023 20:27
@tulioricci tulioricci changed the base branch from main to tulio/reorganize_phenolics July 17, 2023 20:17
Base automatically changed from tulio/reorganize_phenolics to main August 22, 2023 15:11
@tulioricci tulioricci changed the base branch from main to tulio/phenolics September 22, 2023 00:33
@tulioricci tulioricci closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants