Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use illinois-ceesd for upstream #919

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Use illinois-ceesd for upstream #919

merged 2 commits into from
Jun 28, 2023

Conversation

MTCam
Copy link
Member

@MTCam MTCam commented Jun 27, 2023

This change set updates to the illinois-ceesd version of the upstream packages of:

  • grudge
  • loopy
  • meshmode
  • pytato
  • arraycontext

.. effectively syncs the upstream packages used by main with those used by CEESD prediction.

CC: @matthiasdiener
Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@MTCam MTCam merged commit 0952c0f into main Jun 28, 2023
13 checks passed
@MTCam MTCam deleted the MTCam-patch-1 branch June 28, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants