Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test production against changes to upstream packages #926

Draft
wants to merge 110 commits into
base: production
Choose a base branch
from

Conversation

MTCam
Copy link
Member

@MTCam MTCam commented Jun 30, 2023

This PR is here just to test current production/prediction code against any changes to upstream packages.

To prepare and run the tests:

  1. Check the CEESD forks of (grudge, meshmode, arraycontext, pytato, and loopy) to see if they lag behind the inducer@main versions (update the CEESD forks if they lag).
  2. Check out illinois-ceesd/pkg@production-pilot for any updated packages and merge the (now updated) illinois-ceesd/pkg@main changes and push
  3. Ensure this mirgecom@production-pilot branch is updated with mirgecom@production and push or otherwise kick CI.

If all of these tests pass, then illinois-ceesd/pkg@production-pilot can be safely merged into illinois-ceesd/pkg@production

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@MTCam MTCam changed the title Use production-pilot upstream packages for testing. Test production against changes to upstream packages Jul 1, 2023
MTCam added 30 commits May 11, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants