Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MixtureEOS tests and more mechanisms #941

Merged
merged 16 commits into from
Aug 4, 2023
Merged

Add MixtureEOS tests and more mechanisms #941

merged 16 commits into from
Aug 4, 2023

Conversation

tulioricci
Copy link
Collaborator

@tulioricci tulioricci commented Jul 28, 2023

  • Mechanisms:

    • Update 7sp UIUC and rename past 7sp mechanism
    • Add mechanism for Y3 prediction
    • Add mechanism for graphite oxidation
  • Add MixtureEOS test.

    • If I am blind and these tests are done somewhere else, I will remove test_eos.
    • If indeed they are not done anywhere else, any other suggestions for tests?

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@tulioricci tulioricci marked this pull request as ready for review July 28, 2023 18:30
@tulioricci tulioricci requested review from MTCam and majosm July 28, 2023 18:30
@tulioricci tulioricci marked this pull request as draft August 1, 2023 23:30
@tulioricci tulioricci changed the title Add more mechanisms Add MixtureEOS tests and more mechanisms Aug 2, 2023
@tulioricci tulioricci marked this pull request as ready for review August 2, 2023 16:18
Copy link
Member

@MTCam MTCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 If we can, we should add the new mechanisms to the existing tests.

@tulioricci tulioricci merged commit 51ef64e into main Aug 4, 2023
13 checks passed
@tulioricci tulioricci deleted the tulio/add_mechs branch August 4, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants