Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NumpyArrayContext support #947

Merged
merged 11 commits into from
Aug 9, 2023
Merged

add NumpyArrayContext support #947

merged 11 commits into from
Aug 9, 2023

Conversation

matthiasdiener
Copy link
Member

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@matthiasdiener matthiasdiener changed the title add NumpyActx support add NumpyArrayContext support Aug 4, 2023
@matthiasdiener matthiasdiener self-assigned this Aug 4, 2023
@matthiasdiener matthiasdiener marked this pull request as ready for review August 4, 2023 21:15
@MTCam
Copy link
Member

MTCam commented Aug 9, 2023

⚠️ Testing with illinois-ceesd/drivers_y3-prediction#39, and https://github.com/illinois-ceesd/mirgecom/tree/production-numpy. Production testing env needs reverted before merge.

@matthiasdiener matthiasdiener mentioned this pull request Aug 9, 2023
8 tasks
@matthiasdiener matthiasdiener enabled auto-merge (squash) August 9, 2023 19:00
@matthiasdiener matthiasdiener merged commit f602d08 into main Aug 9, 2023
13 checks passed
@matthiasdiener matthiasdiener deleted the numpyactx-support branch August 9, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants