Skip to content

Commit

Permalink
Remove unused shouldCheckFeedback parameter (#299)
Browse files Browse the repository at this point in the history
* Remove unused `shouldCheckFeedback` parameter

* Update CHANGELOG

* Remove unused eslint rule disable
  • Loading branch information
james9909 authored Dec 9, 2019
1 parent 2a0b128 commit d4666d9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ When a new version is tagged, the changes since the last deploy should be labele
with the current semantic version and the next changes should go under a **[Next]** header.

## [Next]
* Fix question feedback submission. ([@james9909](https://github.com/jamse9909) in [#299](https://github.com/illinois/queue/pull/29))

## v1.4.0
* Created a course settings page, which allows for unlisted courses and removal of the question feedback modal. ([@rittikaadhikari](https://github.com/rittikaadhikari) in [#293](https://github.com/illinois/queue/pull/293))
Expand Down
5 changes: 1 addition & 4 deletions src/containers/QuestionListContainer.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,11 @@ const mapStateToProps = (state, props) => ({
const mapDispatchToProps = (dispatch, { queueId }) => ({
fetchQuestions: () => dispatch(fetchQuestions(queueId)),
deleteQuestion: questionId => dispatch(deleteQuestion(queueId, questionId)),
// eslint-disable-next-line max-len
updateQuestionBeingAnswered: (questionId, beingAnswered) =>
dispatch(updateQuestionAnswering(questionId, beingAnswered)),
// eslint-disable-next-line max-len
updateQuestion: (questionId, attributes) =>
dispatch(updateQuestion(questionId, attributes)),
// eslint-disable-next-line max-len
finishAnsweringQuestion: (questionId, shouldCheckFeedback, feedback) =>
finishAnsweringQuestion: (questionId, feedback) =>
dispatch(finishAnsweringQuestion(queueId, questionId, feedback)),
})

Expand Down

0 comments on commit d4666d9

Please sign in to comment.