-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ColPali with double-head architecture #22
Closed
tonywu71
wants to merge
13
commits into
fix-restructured-package
from
add-colpali-with-double-head-architecture
Closed
Add ColPali with double-head architecture #22
tonywu71
wants to merge
13
commits into
fix-restructured-package
from
add-colpali-with-double-head-architecture
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManuelFay
reviewed
Aug 28, 2024
loss_rowwise = self.matryoshka_loss(scores, torch.arange(scores.shape[0], device=scores.device)) | ||
return loss_rowwise | ||
|
||
def multi_vector_loss(self, query_embeddings, doc_embeddings) -> torch.Tensor: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will eventually have to be rebased for the mined negatives to work
tonywu71
force-pushed
the
add-colpali-with-double-head-architecture
branch
from
September 1, 2024 15:51
82f1083
to
e0786f3
Compare
tonywu71
force-pushed
the
add-colpali-with-double-head-architecture
branch
from
September 9, 2024 14:30
9453e04
to
dc28fe0
Compare
tonywu71
force-pushed
the
add-colpali-with-double-head-architecture
branch
from
September 10, 2024 14:19
dc28fe0
to
f31b4a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Create a variant of ColPali that can output both dense and multi-vector embeddings.