atge: register L1C reset funtction in atge_l1c_mii_ops table #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmcd
reviewed
Jul 7, 2021
There was a problem hiding this comment.
You need to mail the illumos developers list. We don't do direct PRs. This PR, however, is a good place to POINT the list so they can review it.
Also, apart from fixing your problem, you may need some folks to confirm THEIR atge devices are still working (I suspect they will, but to integrate you need to generate tests.).
See here for the process: https://illumos.org/docs/contributing/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On NIC's with Atheros AR8151 v2.0 the atge driver has a problem if you disconnect the network cable on a running interface.
The error message reads as follows:
May 23 16:14:56 notebookcg2 atge: [ID 451854 kern.warning] WARNING: atge0: L1C chip detected a fatal error, interrupt status: 200
May 23 16:14:56 notebookcg2 atge: [ID 451854 kern.warning] WARNING: atge0: DMA read error
May 23 16:14:56 notebookcg2 atge: [ID 451854 kern.warning] WARNING: atge0: atge_device_stop() stopping TX/RX MAC timeout
After this error the interface will not work anymore until you remove the interface and reconfigure it again.
With this fix the interface will be reset on link down and will work as intended on link up.
I altered the atge_l1c_mii_reset function and used freebsd driver alc as guidance.