Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARCH-2011 - Adding tests & upgrading node #21

Merged
merged 14 commits into from
Feb 28, 2024
Merged

Conversation

danielle-casella-adams
Copy link
Contributor

Summary of PR changes

Changes for Testing:

  • Adding tests for the action in build-and-review-pr.yml
  • Adding new outputs to facilitate testing
    • status-check-ids
    • pr-comment-id
    • test-results-file-path

Additional Changes:

  • Small improvements to code for clarity/efficiency
  • Fixed the whitespace in the markup generated so it is valid markup
  • Renamed some functions & variables to make it clearer what they are doing
  • Update to Node 20. (Can be done by including PR #35)
  • Adding the ability to truncate messages that are too long automatically
  • Adding an identifier in the markup prefix that matches the recent change in process-cypress-test-results

PR Requirements

  • For major, minor, or breaking changes, at least one of the commit messages contains the appropriate +semver: keywords.
    • See the Incrementing the Version section of the repository's README.md for more details.
  • The action code does not contain sensitive information.

NOTE: If the repo's workflow could not automatically update the README.md, it should be updated manually with the next version. For javascript actions, if the repo's workflow could not automatically recompile the action it should also be updated manually as part of the PR.

@danielle-casella-adams danielle-casella-adams requested a review from a team as a code owner February 23, 2024 22:41
Copy link

Before this PR can be merged, the following item(s) should be addressed to comply with the action's Contributing Guidelines.

  • Please ensure the action has been recompiled by running the following command from the root of the repository:
    npm run build

@danielle-casella-adams danielle-casella-adams merged commit 25f3784 into main Feb 28, 2024
8 checks passed
@danielle-casella-adams danielle-casella-adams deleted the adding-tests branch February 28, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants