Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv-zig-blink example improvements #628

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

michalsieron
Copy link

  • remove riscv64-unknown-elf-objcopy dependency - Zig can emit bin file on its own
  • set expected exit code to 74 so zig build run does not fail on successful binary upload
  • small syntactic fix for unnecessary pointer dereferencing

@michalsieron
Copy link
Author

Actually when I tried to do some Messible output, USB did reset correctly and exit code was 0.
But still, default example returns 74.
Maybe it is better to just run_cmd.expected_exit_code = null, so the exit code will be ignored?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant