Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove useless check #431

Merged
merged 1 commit into from
Feb 13, 2024
+0 −1
Merged

fix: remove useless check #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/compute/getExtrema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
const { kind = 'maximum', mask, algorithm = 'star', maxEquals = 2 } = options;
checkProcessable(image, {
bitDepth: [8, 16],
components: image.components,
});
const searchingMinimum = kind === 'minimum';

Expand Down Expand Up @@ -92,7 +91,7 @@
}
}

// TODO How to make a more performant and general way

Check warning on line 94 in src/compute/getExtrema.ts

View workflow job for this annotation

GitHub Actions / nodejs / lint-eslint 

Unexpected 'todo' comment: 'TODO How to make a more performant and...'
// we don't deal correctly here with groups of points that should be grouped if at the
// beginning one of them is closer to another
// Seems that we would ened to calculate a matrix and then split this matrix in 'independant matrices'
Expand Down
Loading