Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CMYKA #208

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add CMYKA #208

wants to merge 2 commits into from

Conversation

luksab
Copy link
Contributor

@luksab luksab commented Jul 23, 2023

As described in #207, this PR adds the CMYKA8 color type.

fintelia
fintelia approved these changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@fintelia fintelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However, since ColorType isn't marked non-exhaustive, this is a breaking change and will have to wait for the next major release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fintelia fintelia fintelia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luksab @fintelia