Eliminate bounds checks in read_coefficients() (for zero performance gain?)
#121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've removed the % hack that increased complexity, so now this also works as a refactoring. |
HeroicKatora
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all bounds checks from the hot loop of
read_coefficients(). Workshopped by staring at the assembly usingcargo-show-asmon baseline x86_64.This function's execution (excluding other functions it calls) accounts for 20% of the time on the profile from #71. Despite that, I could not measure any difference in end-to-end performance on my machine. So feel free to reject this PR.