fix signed url #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur-dwivedi
commented
May 18, 2024
| if !cmp.Equal(tr, expectedTr) { | ||
| t.Errorf("url: %s, expected tr: %s\ngot tr: %s", tc.url, expectedTr, tr) | ||
| } | ||
| if !urlsEquals(url, tc.url) { |
There was a problem hiding this comment.
There was only an assertion for URLs containing tr: inside the path, so
here added an assertion that will test all the URLs.
ankur-dwivedi
commented
May 18, 2024
ankur-dwivedi
commented
May 18, 2024
| } | ||
| }) | ||
| } | ||
|
|
||
| } | ||
|
|
||
| func extractTransformation(t *testing.T, url string) (urlResult string, trResult []string) { |
There was a problem hiding this comment.
I removed this because it was not needed anymore. This function removes transformations from the path and checks whether they exist in the URL. Now, we are directly matching URLs.
This was needed earlier because the sequence of transformation was not fixed earlier refer here
|
LGTM. |
ahnv
reviewed
May 20, 2024
| @@ -76,6 +73,43 @@ func TestUrl(t *testing.T) { | |||
| }, | |||
| url: "https://ik.imagekit.io/test/default-image.jpg?ik-t=1653775928&ik-s=48842eca663c6895331331db6c90f262c601f4e8", | |||
| }, { | |||
| name: "signed-url-with-transformation", | |||
There was a problem hiding this comment.
can we add a test case for signed url without expiry
There was a problem hiding this comment.
done added a test case for signed URL without expiry
|
LGTM |
ahnv
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/3af1e2e44f8c455592ed902cfcbc9272?sid=fc11605a-39b4-45cc-b0b5-3206b6dfa0a6