-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update static Linux build to MozJPEG 4.0. #57
base: main
Are you sure you want to change the base?
Conversation
Also I don't think the CI is checking this branch since it downloads from GitHub master right? I tested on my own machine though. |
e8bfff2
to
9bc1591
Compare
@a-vrma Do you mean |
No, CMake sets it by default. Try adding
anywhere in the CMakeLists.txt and it will output
This doesn't happen on every CMake project (not mine) but the libjpeg-turbo CMakeLists is very large and very old (version 2.8) and I'm not sure how exactly to debug it so that was my quick fix. |
@a-vrma Ok. Now I understand. Thanks for the clarification and great job on the script. |
Actually I just found out it gets set in
|
9bc1591
to
3db8006
Compare
Link in libc too so it works on Alpine and other non-glibc based distros and add a SOURCE_DATE_EPOCH so the build is reproducible.
3db8006
to
a16c78f
Compare
Cleaned up the script and updated to MozJPEG 4.1.1. This is also a good base upon which to build Linux aarch64 support like in #75 but reproducible. |
After merging #80 I think this pull request can be closed or you should updated your pull request to match current main branch. |
Statically link with libc too so it works on Alpine and other
non-glibc based distros and add a SOURCE_DATE_EPOCH so the build is
reproducible.
This will partly fix #56. It will also fix #47. It might help with #35 because I think one of the issues might have been that the previous binary wasn't actually statically linked:
As you can see, it links dynamically against libc, libm, and zlib.
If you have some free time, please run
npm run build-linux
on this branch andcheck if the SHA-256 hash of
vendor/linux/cjpeg
is the same as what I pushed, which is