update composer.json for laravel 11 #30
Conversation
WalkthroughThe pull request updates the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
composer.json (1)
Line range hint
33-34: Update development dependencies for Laravel 11 compatibilityThe development dependencies are outdated and might not support newer Laravel/PHP versions:
orchestra/testbench~3.0 is very oldmockery/mockery^0.9.9 is outdatedConsider updating to:
"require-dev": { - "orchestra/testbench": "~3.0", - "mockery/mockery": "^0.9.9" + "orchestra/testbench": "^8.0", + "mockery/mockery": "^1.6" },
🧹 Nitpick comments (1)
composer.json (1)
25-25: Consider updating minimum PHP version requirementsWhile adding PHP 8.3 support is good, maintaining compatibility with PHP versions below 8.1 might pose security risks as they're no longer supported. Additionally, Laravel 11 requires PHP 8.2+, so the lower bounds could be raised.
Consider updating the PHP version constraint to:
-"php": "7.2.*|7.3.*|7.4.*|8.0.*|8.1.*|8.2.*|8.3.*", +"php": "^8.2",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
composer.json(1 hunks)
🔇 Additional comments (1)
composer.json (1)
26-26: Verify Laravel version compatibility range
The extremely wide Laravel version range (5.1 through 11) raises some concerns:
- Laravel 11 is not yet released (expected Q1 2024)
- Supporting such a wide range of versions might lead to compatibility issues
Please verify:
- That the package features work correctly across all supported versions
- Consider using semantic versioning with a more focused range
✅ Verification successful
Let me check the actual usage of Laravel-specific features to better understand the compatibility requirements.
Wide Laravel version range is acceptable for this package
After analyzing the codebase, I can confirm that the wide Laravel version range (5.1 through 11) is acceptable because:
- The package has minimal Laravel dependencies, only using basic service provider functionality (
mergeConfigFromandpublishes) which has remained stable across Laravel versions - The core functionality (video streaming) relies on PHP's native functions (
fopen,filesize,header) rather than Laravel-specific features - No usage of version-sensitive Laravel components like Eloquent, Request handling, or Authentication is found
The package's simplicity and focus on PHP native functions makes it highly compatible across Laravel versions. The early inclusion of Laravel 11 is also acceptable as the package doesn't use any features that would be affected by the new version.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for potential breaking changes in Laravel versions
# Look for Laravel-specific method calls that might have changed across versions
rg -l "(?i)(response|request|config|route|view|auth|session|cache|storage|file|db|schema|artisan)" src/
# Check test suite compatibility
cat tests/TestCase.php
Length of output: 229
Script:
#!/bin/bash
# Check Laravel-specific features usage in the codebase
rg -A 3 "(?i)(response|request|config|route|view|auth|session|cache|storage|file|db|schema|artisan)" src/
# Check composer.json for package details and description
cat composer.json
Length of output: 3876
Hi
This package works great with laravel 11 and php 8.3 !
This PR updates composer.json
hth
Summary by CodeRabbit