Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] 重构 RequestContext #654

Merged
merged 3 commits into from
Nov 25, 2023
Merged

[3.0] 重构 RequestContext #654

merged 3 commits into from
Nov 25, 2023

Conversation

Yurunsoft
Copy link
Member

@Yurunsoft Yurunsoft commented Nov 25, 2023

  • flag 改名为 id
  • 引入新的上下文对象类 ContextData,并支持所有环境下的 defer()
  • Swoole 环境下的上下文,不直接使用 Swoole 上下文,也是使用 ContextData
  • 计划废弃 IMI.REQUEST_CONTENT.DESTROY 事件,可以用 defer() 代替。将在连接中心代替旧版连接池后正式废弃!

@Yurunsoft Yurunsoft added enhancement New feature or request 3.0 Plan version 3.0 labels Nov 25, 2023
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (3043be4) 66.62% compared to head (0fb558b) 66.71%.

Files Patch % Lines
...nts/swoole/src/Context/CoroutineContextManager.php 67.92% 17 Missing ⚠️
src/Core/Context/DefaultContextManager.php 70.00% 6 Missing ⚠️
src/RequestContext.php 81.25% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.0     #654      +/-   ##
============================================
+ Coverage     66.62%   66.71%   +0.09%     
- Complexity    10769    10777       +8     
============================================
  Files           870      871       +1     
  Lines         29222    29244      +22     
============================================
+ Hits          19469    19511      +42     
+ Misses         9753     9733      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yurunsoft Yurunsoft merged commit f1d3c2e into 3.0 Nov 25, 2023
@Yurunsoft Yurunsoft deleted the requestContext-3.0 branch November 25, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 Plan version 3.0 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant