Fix hypha RPC issue (#355)

* bump version * bump version
imjoy-team · May 6, 2022 · 580f0ab · 580f0ab
1 parent 94239c6
commit 580f0ab
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 10 deletions.
diff --git a/javascript/package-lock.json b/javascript/package-lock.json
diff --git a/javascript/package.json b/javascript/package.json
@@ -1,6 +1,6 @@
 {
   "name": "imjoy-rpc",
-  "version": "0.5.11",
+  "version": "0.5.12",
   "description": "Remote procedure calls for ImJoy.",
   "module": "index.js",
   "scripts": {

diff --git a/python/imjoy_rpc/VERSION b/python/imjoy_rpc/VERSION
@@ -1,3 +1,3 @@
 {
-    "version": "0.5.11"
+    "version": "0.5.12"
 }
diff --git a/python/imjoy_rpc/hypha/rpc.py b/python/imjoy_rpc/hypha/rpc.py
@@ -907,13 +907,19 @@ async def heartbeat(interval):
                                 await promise["heartbeat"]()
                             except asyncio.CancelledError:
                                 break
-                            except Exception:  # pylint: disable=broad-except
-                                if method_task and not method_task.done():
-                                    logger.error(
-                                        "Failed to reset the heartbeat timer: %s",
-                                        data["method"],
-                                    )
-                                    method_task.cancel()
+                            except Exception as exp:  # pylint: disable=broad-except
+                                logger.error(
+                                    "Failed to reset the heartbeat timer: %s, error: %s",
+                                    data["method"],
+                                    exp,
+                                )
+                                # TODO: We need more investigation here
+                                # If the method task is cancelled
+                                # It put the entire RPC in a bad state that can never recover
+                                # if method_task and not method_task.done():
+                                #     method_task.cancel()
+                                # break
+                            if method_task and not method_task.done():
                                 break
                             await asyncio.sleep(interval)