Skip to content

Commit

Permalink
test_fault_handler: exit nonzero if expected segfault missing
Browse files Browse the repository at this point in the history
we previously tested for the printed message with FileCheck, but now our criterion-based tests care about exit codes

this was hiding test failures on ARM64
  • Loading branch information
fw-immunant committed Jul 23, 2024
1 parent 7a47eb5 commit 63f7e4d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion runtime/libia2/include/test_fault_handler.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
asm volatile("" : : : "memory"); \
volatile typeof(expr) _tmp = expr; \
printf("CHECK_VIOLATION: did not seg fault as expected\n"); \
_exit(0); \
_exit(1); \
_tmp; \
})

Expand Down

0 comments on commit 63f7e4d

Please sign in to comment.