Skip to content

Commit

Permalink
Fix propagation of partition-alloc link options
Browse files Browse the repository at this point in the history
The partition-alloc module exported public linker options, but this was not propagated through the padded version of the library. This change propagates PUBLIC LINK_OPTIONS from partition-alloc to its consumers.
  • Loading branch information
rinon committed Oct 4, 2024
1 parent deeab9a commit 98fff44
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
1 change: 1 addition & 0 deletions cmake/ia2.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ function(pad_tls_library INPUT OUTPUT)
LIBRARY_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/unpadded"
OUTPUT_NAME "${OUTPUT}"
)
target_link_options(${OUTPUT} INTERFACE $<TARGET_PROPERTY:${INPUT},INTERFACE_LINK_OPTIONS>)
endfunction()

# Create a fake target that builds the given sources
Expand Down
2 changes: 1 addition & 1 deletion tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ if (NOT LIBIA2_AARCH64)
add_subdirectory(two_keys_minimal)
add_subdirectory(two_shared_ranges)
# TODO(#413): Fix these tests
# add_subdirectory(heap_two_keys)
add_subdirectory(heap_two_keys)
# add_subdirectory(three_keys_minimal)

# strange bug with indirect calls
Expand Down
3 changes: 1 addition & 2 deletions tests/lit.cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
config.excludes = [entry.name for entry in os.scandir(os.path.dirname(os.path.abspath(__file__))) if entry.name not in [
'global_fn_ptr',
'header_includes',
# TODO(#413)
# 'heap_two_keys',
'heap_two_keys',
'macro_attr',
'minimal',
'mmap_loop',
Expand Down

0 comments on commit 98fff44

Please sign in to comment.