Skip to content

Commit

Permalink
Remove outdated stack size adjustment
Browse files Browse the repository at this point in the history
We don't save the function pointer to the stack anymore, so we shouldn't be adding a slot in the indirect call wrapper case. This wasn't breaking anything unless we had a return value on the stack.
  • Loading branch information
rinon committed Oct 3, 2024
1 parent 5d7ddf9 commit bfbb857
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions tools/rewriter/GenCallAsm.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -646,10 +646,6 @@ std::string emit_asm_wrapper(const CAbiSignature &sig,
size_t stack_return_align = 16;
size_t stack_return_padding = 0;
size_t start_of_ret_space = 0;
if (kind == WrapperKind::IndirectCallsite) {
// Count the space for the function pointer if the call is indirect.
start_of_ret_space += 8;
}

if (stack_return_size > 0) {
// If we have a stack return, we also have to save the old ret ptr, which
Expand Down

0 comments on commit bfbb857

Please sign in to comment.