Improve testing framework #286
Conversation
rinon
changed the title
|
@sim-immunant here's my start to cleaning up the testing framework. I don't think we're getting much out of More context is in #154 |
|
I would absolutely like to get rid of |
rewriter/tests/mmap_loop/main.c
Outdated
| int res = munmap(lib_buf_mmap, 4096); | ||
| cr_log_info(res ? |
There was a problem hiding this comment.
Stylistically I prefer putting separate calls under and if branch, especially since we already have one.
rewriter/tests/ro_sharing/main.c
Outdated
| Test(ro_sharing, plugin, .exit_code = 255) { | ||
| cr_log_info("%s", get_plugin_str()); | ||
| cr_log_info("0x%x", *get_plugin_uint(false)); | ||
| cr_log_info("0x%x", *get_plugin_uint(true)); |
There was a problem hiding this comment.
Can't we put the CHECK_VIOLATION around the get_plugin_uint deref?
rewriter/tests/ro_sharing/plugin.c
Outdated
|
|
||
| // Check that we can't read a pointer to data passed from main | ||
| // TODO can we change this LOG to cr_log_info? | ||
| CHECK_VIOLATION(LOG("0x%x", *secret)); |
There was a problem hiding this comment.
Yes, change this to a cr_log and put the CHECK_VIOLATION around the *secret if we can?
| // LINKARGS: --wrap=call_operation | ||
| uint32_t call_operation(size_t i) { | ||
| // TODO: Add a way to share strings between compartments | ||
| //printf("%s\n", operations[i].desc.data); |
There was a problem hiding this comment.
nit: I think we can remove the comment on the printf and the TODO We previously treated the .rodata sections (where string literals are placed) as secret, but we have since moved on to only treating writable sections that way.
We don't have a --function-allowlist anymore, so this is testing nothing.
sim-immunant
force-pushed
the
sjc/improve_testing
branch
from
f27b74a to
40f076b
Compare
No description provided.