Remove lit #305
Remove lit #305
Conversation
sim-immunant
force-pushed
the
remove-lit
branch
from
a4b7c74 to
bd30cc5
Compare
| @@ -6,7 +6,6 @@ message(STATUS "Found LLVM: ${LLVM_DIR} (found version \"${LLVM_PACKAGE_VERSION} | |||
| find_package(Clang REQUIRED CONFIG) | |||
| message(STATUS "Found Clang: ${Clang_DIR}") | |||
|
|
|||
| # We use the lit CMake functions from LLVM | |||
There was a problem hiding this comment.
Check-ia2 works without these lines but nginx build seems to need these
| /* | ||
| RUN: cp %s %t.h | ||
| RUN: ia2-rewriter --omit-wrappers %t.c %t.h -- -I%resource_dir | ||
| RUN: sh -c "[ ! -e %t.c.args ]" |
There was a problem hiding this comment.
Not sure what this is doing. Is the Criterion test sufficient to test what this is testing?
There was a problem hiding this comment.
Sorry that's my bad, this test should've been removed when we switched over to the source rewriter. The header rewriter required more flags to get it working on real codebases and this was testing one of those flags.
|
I thought we settled on keeping lit but making it opt-in rather than opt-out.
I don't think we can necessarily assume that because a test builds and runs that some of these things are correct. The segment tests aren't necessary anymore since our linker script (libia2/padding.ld) is much simpler than before and shouldn't accidentally change segment permissions like we noticed before. For linker args we can assume the call gates were inserted if the test coverage is sufficient. I wouldn't bother with removing the existing linker args tests if a directory needs lit tests though, it's just something to keep in mind for new tests. For rewriter changes we definitely want explicit lit tests. |
|
Since we've decided not to remove lit but instead to reduce its scope and make it opt-in rather than automatic, I'm going to close this PR and make a new one that's freshly branched off main. |
This PR completely removes lit.
Notably, Criterion does not test certain things such as segments, linker args, or that the rewriter produces the exact output, as lit did. My hope and belief is that the fact that the test compiles and passes is evidence that these are as expected.